Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade cpu workers to ubuntu 24.04 generic-worker image #949

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bhearsum
Copy link
Collaborator

@bhearsum bhearsum commented Nov 27, 2024

This will remove docker-worker from translations, and use the most recent generic-worker version instead. This halfway unblocks #375 and #466 (the other half is upgrading the GPU workers to this image, which is still in progress).

The other notable part of this is that it moves these workers to a common shared image that will be updated regularly. This means that we'll regularly be picking up things like Taskcluster version upgrades. There are risks to this of course, in that any change to the image can theoretically cause issues with tasks that use it. Over in mozilla-releng/fxci-config#192, I'm working on adding the ability for us to run the training pipeline to help validate new images before they land to help minimize this.

We may also want to consider pinning to a specific image the next time we cut a release branch to minimize risk/change during long training sessions.

(If someone wants to make the case that we should always pin to a specific image rather than a rolling one, we can consider that.)

@bhearsum
Copy link
Collaborator Author

bhearsum commented Dec 2, 2024

This change originally included a forced cache bust to make sure the entire pipeline ran, which I've since removed to avoid taking it on main. That graph is https://firefox-ci-tc.services.mozilla.com/tasks/EyBbWlbmTpCQOT0Lwtp7pw, and confirms that the pipeline runs fine on the new image.

@bhearsum bhearsum marked this pull request as ready for review December 2, 2024 17:29
@bhearsum bhearsum requested review from a team as code owners December 2, 2024 17:29
@bhearsum bhearsum requested review from gabrielBusta and removed request for a team and gabrielBusta December 2, 2024 17:29
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but I'd like @eu9ene's review as well.

@gregtatum gregtatum requested a review from eu9ene December 3, 2024 15:45
taskcluster/config.yml Outdated Show resolved Hide resolved
This will remove docker-worker from translations, and use the most recent generic-worker version instead.
@bhearsum bhearsum merged commit 70307e3 into mozilla:main Dec 17, 2024
9 checks passed
ZJaume pushed a commit that referenced this pull request Jan 16, 2025
This will remove docker-worker from translations, and use the most recent generic-worker version instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants