-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cron task that runs the minimal training pipeline nightly #966
Conversation
1201a66
to
ecf5c4a
Compare
It looks like the defaults updating is causing some issues (either with some test assumptions, or genuine issues); moving back into draft while I work that out. |
7dcb285
to
11251f1
Compare
This turns out not to be necessary, so I removed it! (The defaults end up getting set in the parameters:
This is ready for review now, but it does have #962 cherry picked to it to ensure the correct kind name is used. This isn't landable until that merges and I rebase on top of it. |
cbc9e4c is the only part that needs review here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of wondering if the cron job shouldn't be using an action instead of decision-task. That'd be a bit more code but wouldn't require the special-casing in get_decision_parameters.
Also, does this really need to run daily (vs weekly for gecko's os-integration cron)?
Hmm...I do recall looking at that, but I'm not sure why that didn't work out. Or I might be confusing that with the abandoned mozilla-releng/fxci-config#192. I'll have a second look at this though; I agree that's cleaner if it works out.
I think daily is actually more appropriate for this, because all meaningful tasks will be cached 99% of the time. Daily lets us virtually eliminate the possibility that an image change will run against outdated versions of these tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ to make it clear my comment isn't meant to be blocking.
I gave |
cbc9e4c
to
e99cab8
Compare
e99cab8
to
853ef48
Compare
Relates to https://bugzilla.mozilla.org/show_bug.cgi?id=1937882, where we're adding integration tests for the translations pipeline in mozilla-releng/fxci-config#210. These work by looking a decision task and rerunning the tasks it creates (and those upstream of it). Running the pipeline on a cron schedule allows us to have an easily findable, up to date, decision task to point the tests at.