Display the should_alert field in Graphs Legend

[beatrice-acasandrei]

For testing locally, either use the staging connection or ingest some alerts to look at the corresponding graphs.
alert_change_type and alert_threshold can have a null value.

[beatrice-acasandrei]

@gmierz Do you have suggestions on how to display these values? Since should_alert can be null, I was thinking to display the value as True instead of null so it's less confusing.
alert_change_type can be either null, 0 or 1. Should I display also the information that 0 is percentage and 1 is absolute?
Is there any documentation regarding these fields (we could provide the links for further context)?

[gmierz]

@gmierz Do you have suggestions on how to display these values? Since should_alert can be null, I was thinking to display the value as True instead of null so it's less confusing.

I agree on displaying True instead of null. Something to note is that there is also some logic or an edge case where if a suite has a should_alert value of null/True AND there is a suite-level value, but the subtests don't have a should_alert set to True, then those subtests won't alert (or a null for them would mean that should_alert is False). I don't think this is being handled in the current code that you have. This happens in cases like browsertime benchmarks, or AWSY.

Should I display also the information that 0 is percentage and 1 is absolute?

Yes, that sounds good. You could also only display "absolute" if it's 1, and "percentage" otherwise.

Is there any documentation regarding these fields (we could provide the links for further context)?

There's no documentation about these fields. I can file a ticket to get some made though.