Bug 1923923 - Reuse BugJobMap instead of BugscacheOccurrence #8467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrigal
force-pushed
the
internal-bugjobmap
branch
from
63b81f5 to
ec8a4d2
Compare
vrigal
force-pushed
the
internal-bugjobmap
branch
from
ec8a4d2 to
a2a25eb
Compare
vrigal
force-pushed
the
internal-bugjobmap
branch
from
a2a25eb to
c262718
Compare
vrigal
changed the title
jmaher
approved these changes
Feb 1, 2025
| @@ -772,12 +754,22 @@ def who(self): | |||
| return "autoclassifier" | |||
|
|
|||
| @classmethod | |||
| def create(cls, job_id, bug_id, user=None, bug_open=False): | |||
| def create(cls, *, job_id, internal_bug_id=None, bugzilla_id=None, user=None, bug_open=False): | |||
There was a problem hiding this comment.
what is the * as a parameter?
| def create(cls, job_id, bug_id, user=None, bug_open=False): | ||
| def create(cls, *, job_id, internal_bug_id=None, bugzilla_id=None, user=None, bug_open=False): | ||
| if (bool(internal_bug_id) ^ bool(bugzilla_id)) is False: | ||
| raise ValueError("Only one of internal bug ID or Bugzilla ID must be set") |
There was a problem hiding this comment.
won't we always have internal_bug_id set, but optionally have bugzilla-id set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.