Bug 1919588 - Add new alert tables, along with new fields to existing table. #8470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmierz
requested review from
beatrice-acasandrei and
esanuandra
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new alert table for testing new detection techniques. Some things are changed with the alert table definitions to be able to reuse a lot of the code in the new tables. At the same time, one of the methods (autodetermine_status) is modified to be more generic and usable by subclasses.
Two new fields are added called confidence, and detection_method. The confidence field is a more generically termed field similar to the t_value field but isn't specific to T-test. The detection_method field will be used to store the name of the detection method used to produce the alert.
Additionally, a new table for telemetry alerts is added here, and makes use of the *Base classes that were added.