Prevent Swift objects' deinit from trying to free a nil pointer when subclassed for mocking
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conceptually this seems correct, but the swift compiler doesn't seem to like it :) |
|
Oh interesting, let me try something.. |
…n subclassed for mocking - doing so will result in a `Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value` - deinit is not overridable in Swift and this cannot be handled in the subclass
stefanceriu
force-pushed
the
stefan/fixMockDeallocationCrashes
branch
from
aab4541
to
85e1965
Compare
|
Okay, it's happy now. While |
|
Yey, thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #1918 and implicitly #1975 missed one important aspect when opening up classes for mocking:
pointeris nil in those cases and doing so will result in aFatal error: Unexpectedly found nil while implicitly unwrapping an Optional valueThis PR attempts to fix the problem by introducing a guard to check that
pointeris not nil before trying to free it.