Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use replaceSkuWithProductName #101

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Use new server setting rather than webs

Testing Plan

  • Tested in simulator

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but let's wait for the SQL change to merge first before merging just in case something happens to the setting name.

@BrandonStalnaker BrandonStalnaker merged commit 1033ef6 into development Dec 11, 2024
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-6887-update-server-setting branch December 11, 2024 20:54
mparticle-automation added a commit that referenced this pull request Dec 11, 2024
# [8.12.0](v8.11.0...v8.12.0) (2024-12-11)

### Features

* Use replaceSkuWithProductName ([#101](#101)) ([1033ef6](1033ef6))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants