Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent mpid with value 0 to forward to Braze #99

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix: prevent mpid with value 0 to forward to Braze #99

merged 2 commits into from
Nov 4, 2024

Conversation

mmustafa-tse
Copy link
Contributor

Summary

  • A customer have recently noticed that they have a profile in Braze with value 0 where they have in their configuration to forward the MPID as the external identity. We were able to reproduce with only apps built with Obj C while swift apps didn't reproduce the issue. After further further investigation we noticed that we create in our identityAPI an MParticleUser with MPID = 0 on first installs before mParticle is initialized and forward it to Braze.

Testing Plan

  • [Y] Was this tested locally? If not, explain why.
  • E2E tested with enabling Braze logs where the Braze message "Changed to user 0" stopped appearing with the fix
  • Unit tests were also included for cases where MPID is zero, positive or negative

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 69255c2 into mparticle-integrations:development Nov 4, 2024
3 checks passed
mparticle-automation added a commit that referenced this pull request Nov 6, 2024
@mparticle-automation
chore(release): 8.10.2 [skip ci]
23f703d 
## [8.10.2](v8.10.1...v8.10.2) (2024-11-06)

### Bug Fixes

* prevent mpid with value 0 to forward to Braze ([#99](#99)) ([69255c2](69255c2))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmustafa-tse @mparticle-automation @BrandonStalnaker