Fees for Tx building

examples/txbuild/Main.elm

@@ -18,7 +18,7 @@ main =
 example ex =
     case ex () of
         Err error ->
-            error
+            Debug.toString error
 
         Ok tx ->
             Cardano.prettyTx tx
@@ -31,10 +31,11 @@ example ex =
 view : () -> Html ()
 view _ =
     div []
-        [ div [] [ text "Example transaction 1: send 1 ada from me to you" ]
+        [ div [] [ text "Example transaction 1: send 1 ada from me to you." ]
         , Html.pre [] [ text <| example Cardano.example1 ]
-        , div [] [ text "Example transaction 2: mint dog & burn 1 cat" ]
+        , div [] [ text "Example transaction 2: mint 1 dog & burn 1 cat." ]
         , Html.pre [] [ text <| example Cardano.example2 ]
-        , div [] [ text "Example transaction 3: spend 1 ada from a plutus script with 2 ada" ]
+        , div [] [ text "Example transaction 3: spend 1 ada from a plutus script with 2 ada." ]
+        , div [] [ text "Spent UTxO index is passed as argument in the redeemer." ]
         , Html.pre [] [ text <| example Cardano.example3 ]
         ]

src/Cardano/Address.elm

@@ -2,9 +2,9 @@ module Cardano.Address exposing
     ( Address(..), StakeAddress, NetworkId(..), ByronAddress
     , Credential(..), StakeCredential(..), StakeCredentialPointer, CredentialHash
     , enterprise, script, base, pointer
-    , extractPubKeyHash, extractStakeCredential
-    , Dict, emptyDict
-    , StakeDict, emptyStakeDict
+    , isShelleyWallet, extractPubKeyHash, extractStakeCredential
+    , Dict, emptyDict, dictFromList
+    , StakeDict, emptyStakeDict, stakeDictFromList
     , toCbor, stakeAddressToCbor, credentialToCbor, encodeNetworkId
     , decode, decodeReward
     )
@@ -17,11 +17,11 @@ module Cardano.Address exposing
 
 @docs enterprise, script, base, pointer
 
-@docs extractPubKeyHash, extractStakeCredential
+@docs isShelleyWallet, extractPubKeyHash, extractStakeCredential
 
-@docs Dict, emptyDict
+@docs Dict, emptyDict, dictFromList
 
-@docs StakeDict, emptyStakeDict
+@docs StakeDict, emptyStakeDict, stakeDictFromList
 
 @docs toCbor, stakeAddressToCbor, credentialToCbor, encodeNetworkId
 
@@ -155,6 +155,13 @@ pointer networkId paymentCredential p =
         }
 
 
+{-| Check if an [Address] is of the Shelley type, with a wallet payment key, not a script.
+-}
+isShelleyWallet : Address -> Bool
+isShelleyWallet address =
+    extractPubKeyHash address /= Nothing
+
+
 {-| Extract the pubkey hash of a Shelley wallet address.
 -}
 extractPubKeyHash : Address -> Maybe (Bytes CredentialHash)
@@ -186,34 +193,68 @@ extractStakeCredential address =
 
 {-| Convenient alias for a `Dict` with [Address] keys.
 When converting to a `List`, its keys are sorted by address.
+
+WARNING: do not compare them with `==` since they contain functions.
+
 -}
 type alias Dict a =
     AnyDict String Address a
 
 
 {-| Initialize an empty address dictionary.
 For other operations, use the `AnyDict` module directly.
+
+WARNING: do not compare them with `==` since they contain functions.
+
 -}
 emptyDict : Dict a
 emptyDict =
     Dict.Any.empty (toCbor >> E.encode >> Bytes.fromBytes >> Bytes.toString)
 
 
+{-| Create an address dictionary from a list.
+For other operations, use the `AnyDict` module directly.
+
+WARNING: do not compare them with `==` since they contain functions.
+
+-}
+dictFromList : List ( Address, a ) -> Dict a
+dictFromList =
+    Dict.Any.fromList (toCbor >> E.encode >> Bytes.fromBytes >> Bytes.toString)
+
+
 {-| Convenient alias for a `Dict` with [StakeAddress] keys.
 When converting to a `List`, its keys are sorted by stake address.
+
+WARNING: do not compare them with `==` since they contain functions.
+
 -}
 type alias StakeDict a =
     AnyDict String StakeAddress a
 
 
 {-| Initialize an empty stake address dictionary.
 For other operations, use the `AnyDict` module directly.
+
+WARNING: do not compare them with `==` since they contain functions.
+
 -}
 emptyStakeDict : StakeDict a
 emptyStakeDict =
     Dict.Any.empty (stakeAddressToCbor >> E.encode >> Bytes.fromBytes >> Bytes.toString)
 
 
+{-| Create a stake address dictionary from a list.
+For other operations, use the `AnyDict` module directly.
+
+WARNING: do not compare them with `==` since they contain functions.
+
+-}
+stakeDictFromList : List ( StakeAddress, a ) -> StakeDict a
+stakeDictFromList =
+    Dict.Any.fromList (stakeAddressToCbor >> E.encode >> Bytes.fromBytes >> Bytes.toString)
+
+
 {-| Encode an [Address] to CBOR.
 
 Byron addresses are left untouched as we don't plan to have full support of Byron era.

src/Cardano/CoinSelection.elm

@@ -31,7 +31,7 @@ import Natural as N exposing (Natural)
 -}
 type Error
     = MaximumInputCountExceeded
-    | UTxOBalanceInsufficient
+    | UTxOBalanceInsufficient { selectedUtxos : List ( OutputReference, Output ), missingValue : Value }
 
 
 {-| Represents the result of a successful coin selection.
@@ -77,6 +77,8 @@ largestFirst maxInputCount context =
             MultiAsset.split context.targetAmount.assets
 
         sortedAvailableUtxoByLovelace =
+            -- TODO: actually use the "free" lovelace, by substracting the UTxO minAda for sorting
+            -- Create and use a function called "Utxo.compareFreeLovelace"
             List.sortWith (\( _, o1 ) ( _, o2 ) -> reverseOrder Utxo.compareLovelace o1 o2) context.availableUtxos
     in
     -- Select for Ada first
@@ -98,9 +100,12 @@ largestFirst maxInputCount context =
                         Nothing
 
                     else
-                        Just (Value.substract state.accumulatedAmount context.targetAmount)
+                        Just (Value.substract state.accumulatedAmount context.targetAmount |> Value.normalize)
                 }
             )
+        -- TODO: if possible, remove extraneous inputs.
+        -- Indeed, when selecting later CNT, they might contain enough previous CNT too.
+        |> identity
 
 
 type alias SelectionState =
@@ -163,7 +168,14 @@ accumOutputsUntilDone ({ maxInputCount, selectedInputCount, accumulatedAmount, t
     else if not (Value.atLeast targetAmount accumulatedAmount) then
         case availableOutputs of
             [] ->
-                Err UTxOBalanceInsufficient
+                Err
+                    (UTxOBalanceInsufficient
+                        { selectedUtxos = selectedOutputs
+                        , missingValue =
+                            Value.substract targetAmount accumulatedAmount
+                                |> Value.normalize
+                        }
+                    )
 
             utxo :: utxos ->
                 accumOutputsUntilDone

src/Cardano/MultiAsset.elm

@@ -84,10 +84,10 @@ onlyToken policy name amount =
 
 {-| Remove assets with 0 amounts.
 -}
-normalize : MultiAsset Natural -> MultiAsset Natural
-normalize multiAsset =
+normalize : (int -> Bool) -> MultiAsset int -> MultiAsset int
+normalize deletionCheck multiAsset =
     multiAsset
-        |> Bytes.Map.map (Bytes.Map.filter (not << Natural.isZero))
+        |> Bytes.Map.map (Bytes.Map.filter (not << deletionCheck))
         |> Bytes.Map.filter (not << Bytes.Map.isEmpty)