Implemented option to pipe url directly to mpv #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for this project, it's been of great use on my ancient 2007 Macbook Pro - I can use mpv with --hwdec and --vo flags to get hardware accelerated video playback, which on a 17 year old CPU is a very welcome help.
However I was running into the 640x360 issue as in #942, so I decided to write this little patch to allow the URL to be piped directly to mpv and the --ytdl-format player args to be used to control the output instead (in my case limiting the resolution to 720p as the GPU runs out of VRAM)
Happy to make any changes needed (what default values would you suggest setting for the stream dict?)