-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/lint: add clang-format on changed files #15132
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
a867bf4
to
3630129
Compare
4120eca
to
4347812
Compare
Has anyone tried to verify how well this matches our code style by running it on existing files? |
Here's it applied to a few big files: sfan5@bf400f2 As I feared, either the config is not fitting or clang-format is just too opinionated to be applied to all new or changed code. just look at this .defaults =
&(const struct demux_opts){
.enable_cache = -1, // auto
.max_bytes = 150 * 1024 * 1024,
.max_bytes_bw = 50 * 1024 * 1024,
.donate_fw = true,
.min_secs = 1.0,
.min_secs_cache = 1000.0 * 60 * 60,
.seekable_cache = -1,
.index_mode = 1,
.mf_fps = 1.0,
.access_references = true,
.video_back_preroll = -1,
.audio_back_preroll = -1,
.back_seek_size = 60,
.back_batch =
{
[STREAM_VIDEO] = 1,
[STREAM_AUDIO] = 10,
}, .meta_cp = "auto",
}, |
4347812
to
4650297
Compare
@sfan5: Fixed. Any other suggestions? |
The entire codebase is not ready to be clang-formatted and probably never will be, but we can at least check if the changes in new pull requests follow our coding style.
4650297
to
2c02f66
Compare
The entire codebase is not ready to be clang-formatted and probably never will be, but we can at least check if the changes in new pull requests follow our coding style.