Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session/6 #19

Merged
merged 14 commits into from
Sep 5, 2023
Merged

Session/6 #19

merged 14 commits into from
Sep 5, 2023

Conversation

mqkotoo
Copy link
Owner

@mqkotoo mqkotoo commented Sep 1, 2023

課題

#6 対応

対応箇所

  • 使用する API を fetchThrowsWeather() から fetchWeather() に変更する
  • API から受け取った天気状況・最低気温・最高気温を画面に表示する

動作

expected actual
expected
2023-09-01.17.51.35.mov

mqkotoo
mqkotoo commented Sep 1, 2023
View reviewed changes
lib/model/weather_request.dart Outdated Show resolved Hide resolved
lib/service/weather_service.dart Show resolved Hide resolved
lib/model/weather_data.dart Show resolved Hide resolved
lib/view/weather_view/component/weather_forecast.dart Outdated Show resolved Hide resolved
mqkotoo
mqkotoo commented Sep 1, 2023
View reviewed changes
lib/model/weather_data.dart Outdated Show resolved Hide resolved
@mqkotoo mqkotoo marked this pull request as ready for review September 1, 2023 09:14
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Ready for review 🚀

mqkotoo
mqkotoo commented Sep 1, 2023
View reviewed changes
lib/model/weather_data.dart Outdated Show resolved Hide resolved
Yamasaki-pan961
Yamasaki-pan961 reviewed Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@Yamasaki-pan961 Yamasaki-pan961 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一旦コメントしました！

lib/view/weather_view/component/weather_forecast.dart Outdated Show resolved Hide resolved
lib/view/weather_view/component/weather_forecast.dart Outdated Show resolved Hide resolved
lib/model/weather_data.dart Outdated Show resolved Hide resolved
lib/model/weather_data.dart Outdated Show resolved Hide resolved
lib/model/weather_data.dart Outdated Show resolved Hide resolved
Yamasaki-pan961
Yamasaki-pan961 reviewed Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@Yamasaki-pan961 Yamasaki-pan961 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点だけ修正があります！

lib/model/weather_data.dart Outdated Show resolved Hide resolved
Yamasaki-pan961
Yamasaki-pan961 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@Yamasaki-pan961 Yamasaki-pan961 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

わからないことは質問して一つ一つのコードに理由を持って記述されていてステキです✨
LGTM

@mqkotoo mqkotoo merged commit c5da14a into main Sep 5, 2023
3 checks passed
@mqkotoo mqkotoo deleted the session/6 branch September 27, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yamasaki-pan961 Yamasaki-pan961 Yamasaki-pan961 approved these changes

@morikann morikann Awaiting requested review from morikann

@trm11tkr trm11tkr Awaiting requested review from trm11tkr

Assignees

@mqkotoo mqkotoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mqkotoo @Yamasaki-pan961