Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session/7 #20

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Session/7 #20

merged 8 commits into from
Sep 13, 2023

Conversation

mqkotoo
Copy link
Owner

@mqkotoo mqkotoo commented Sep 7, 2023

課題

#8 対応

対応箇所

*freezedでも可

  • json_serializable を利用して、API のレスポンスを独自のクラスに変換する
  • json_serializable を利用して、独自のクラスから API のリクエストを作成する

Freezedjson_serializableを使って、リクエストのクラス(weather_request.dart)、レスポンスを変換するクラス(weather_data)を作成しました。

動作

動作に変更はなし

build.yaml Outdated Show resolved Hide resolved
lib/utils/extention/enum.dart Outdated Show resolved Hide resolved
@mqkotoo
Copy link
Owner Author

mqkotoo commented Sep 7, 2023

余談ですが、今回を機に、ファイル名に合わせて勝手にfreezedクラス作ってくれるスニペット作りました!
Android Studioに意外と便利なのがなくて結局自分で作りました。。
便利になって嬉しいっていうだけです🙇

画面収録-2023-09-07-14 41 25

@mqkotoo mqkotoo marked this pull request as ready for review September 7, 2023 06:04
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Ready for review 🚀

Copy link
Collaborator

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけご確認お願いします!

build.yaml Outdated Show resolved Hide resolved
lib/service/weather_service.dart Show resolved Hide resolved
lib/utils/extention/enum.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです🎉
ご対応ありがとうございます!
LGTM

@mqkotoo mqkotoo merged commit 80dadaf into main Sep 13, 2023
3 checks passed
@mqkotoo mqkotoo deleted the session/7 branch September 27, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants