Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session/8 #21

Merged
merged 34 commits into from
Sep 27, 2023
Merged

Session/8 #21

merged 34 commits into from
Sep 27, 2023

Conversation

mqkotoo
Copy link
Owner

@mqkotoo mqkotoo commented Sep 15, 2023 •
edited
Loading

課題

close #9

対応箇所

  • Riverpodを導入して、天気予報画面の状態管理を見直す
  • アーキテクチャを見直し、ARCHITECTURE.md に記載する
    -> ARCHITECTURE.mdとコードをみた方が早いと思うのでここでは実装に関しての詳細、解説は割愛させていただきます。

動作

変更なし

mqkotoo
mqkotoo commented Sep 18, 2023
View reviewed changes
Copy link
Owner Author

@mqkotoo mqkotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初めてARCHITECTURE.mdを書いて要領があんまりわかってない可能性があるので、アドバイスやフィードバックあればお願い致します。

lib/state/weather_state.dart Outdated Show resolved Hide resolved
analysis_options.yaml Outdated Show resolved Hide resolved
@mqkotoo mqkotoo marked this pull request as ready for review September 19, 2023 00:12
@github-actions
Copy link

Ready for review 🚀

trm11tkr
trm11tkr requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@trm11tkr trm11tkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一旦いくつかコメントさせていただきました！
続きは明日見させていただきます！

analysis_options.yaml Outdated Show resolved Hide resolved
doc/ARCHITECTURE.md Outdated Show resolved Hide resolved
lib/utils/provider/yumemi_weather_client.dart Outdated Show resolved Hide resolved
lib/utils/provider/yumemi_weather_client.dart Outdated Show resolved Hide resolved
lib/service/weather_service.dart Outdated Show resolved Hide resolved
doc/image/architecture.jpg Outdated Show resolved Hide resolved
trm11tkr
trm11tkr reviewed Sep 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
lib/utils/provider/yumemi_weather_client.dart Outdated Show resolved Hide resolved
doc/image/architecture.jpg Outdated Show resolved Hide resolved
trm11tkr
trm11tkr reviewed Sep 21, 2023
View reviewed changes
doc/ARCHITECTURE.md Show resolved Hide resolved
lib/state/weather_state.dart Outdated Show resolved Hide resolved
trm11tkr
trm11tkr requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@trm11tkr trm11tkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントさせていただきました！
実装自体は問題なさそうです！

doc/ARCHITECTURE.md Outdated Show resolved Hide resolved
lib/model/weather_forecast.dart Show resolved Hide resolved
analysis_options.yaml Show resolved Hide resolved
lib/view/weather_view/component/weather_forecast_panel.dart Outdated Show resolved Hide resolved
doc/graph.md Outdated Show resolved Hide resolved
doc/ARCHITECTURE.md Show resolved Hide resolved
trm11tkr
trm11tkr requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@trm11tkr trm11tkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最後に一点だけ修正漏れの対応お願いします…！

doc/ARCHITECTURE.md Outdated Show resolved Hide resolved
trm11tkr
trm11tkr approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@trm11tkr trm11tkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本当にお疲れ様でした！
アーキテクチャを意識した綺麗なコードへの置き換えによって、拡張性・保守性が高くなりましたね ✨
LGTM

@mqkotoo mqkotoo merged commit 1e9e41f into main Sep 27, 2023
3 checks passed
@mqkotoo mqkotoo deleted the session/8 branch September 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trm11tkr trm11tkr trm11tkr approved these changes

@morikann morikann Awaiting requested review from morikann

@Yamasaki-pan961 Yamasaki-pan961 Awaiting requested review from Yamasaki-pan961

Assignees

@mqkotoo mqkotoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session8
2 participants
@mqkotoo @trm11tkr