Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session/10 #23

Merged
merged 36 commits into from
Oct 18, 2023
Merged

Session/10 #23

merged 36 commits into from
Oct 18, 2023

Conversation

mqkotoo
Copy link
Owner

@mqkotoo mqkotoo commented Oct 12, 2023 •
edited
Loading

課題

close #11

対応箇所

  • 特定の条件で、天気予報画面に晴れの画像が表示されること
  • 特定の条件で、天気予報画面に曇りの画像が表示されること
  • 特定の条件で、天気予報画面に雨の画像が表示されること
  • 特定の条件で、天気予報画面に最高気温が表示されること
  • 特定の条件で、天気予報画面に最低気温が表示されること
  • 特定の条件で、天気予報画面にダイアログが表示され、特定のメッセージが表示されること

その他

  • 保守性、安全性向上のためにエラーメッセーを共通化しました。
  • 保守性、安全性向上のためにテストに使うダミーのデータを共通化しました。

動作

動作変更なし

mqkotoo and others added 27 commits October 3, 2023 14:24
Add test utils: set, reset device size
36d6bb1
Create weather_forecast_panel_test.dart
554974b
Add a flutter_svg_test package
c334331
Add key for test
788ddc7
Edit lint rule: @VisibleForTesting
4bea593
Create dummy_data.dart
0b6ea1a
Add riverpod dependencies
0391979
Add WeatherForecastPanel initial screen test
bf4477c
Edit dummy_data.dart etc
422d0d2
Add cloudy case test
3e3a55c
Edit cloudy case test
ac18e70
Add sunny test case
d849f69
Add rainy test case
16ae771
Make semanticsLabel constant for maintainability
71bbee0
Make error message constant for maintainability
3cb461d
Add return failure with invalidParameter case
300e3ff
Add unknown error case test
ac7b6aa
Edit a description of fromJson test case
ad62218
Update how to set screen size, fix some test descriptions
dd15ab0
Move invalidData to dummy_data.dart
ff70884
Format codes
5c7a11a
Format codes
43a65b2
Add CheckedFromJsonException case test
5663050
Add FormatException case test
0253d6e
Delete a unnecessary package
538026c
@mqkotoo
Merge branch 'main' into session/10
eba4515
Fix test setUpAll, teaDownAll
9883591
@mqkotoo mqkotoo marked this pull request as ready for review October 12, 2023 04:45
@github-actions
Copy link

Ready for review 🚀

morikann
morikann reviewed Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一旦レビューさせていただきました！
ご確認よろしくお願いします！

analysis_options.yaml Show resolved Hide resolved
lib/model/weather_condition.dart Outdated Show resolved Hide resolved
lib/utils/error/error_message.dart Show resolved Hide resolved
test/view/weather_forecast_panel_test.dart Outdated Show resolved Hide resolved
test/view/weather_forecast_panel_test.dart Outdated Show resolved Hide resolved
test/view/weather_forecast_panel_test.dart Outdated Show resolved Hide resolved
lib/state/weather_state_notifier.dart Outdated Show resolved Hide resolved
test/view/weather_forecast_panel_test.dart Outdated Show resolved Hide resolved
morikann
morikann reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

五月雨で申し訳ございません🙏
追加でレビューさせていただいたのでご確認よろしくお願いします！

test/utils/utils.dart Outdated Show resolved Hide resolved
test/utils/utils.dart Outdated Show resolved Hide resolved
@mqkotoo mqkotoo requested a review from morikann October 18, 2023 05:41
morikann
morikann reviewed Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最後に一点ご確認よろしくお願いいたします🙏

test/service/weather_service_test.dart Outdated Show resolved Hide resolved
@mqkotoo mqkotoo requested a review from morikann October 18, 2023 07:06
morikann
morikann approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！
LGTM

@mqkotoo mqkotoo merged commit 3ac3c70 into main Oct 18, 2023
3 checks passed
@mqkotoo mqkotoo deleted the session/10 branch October 18, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morikann morikann morikann approved these changes

@trm11tkr trm11tkr Awaiting requested review from trm11tkr

@Yamasaki-pan961 Yamasaki-pan961 Awaiting requested review from Yamasaki-pan961

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session10
2 participants
@mqkotoo @morikann