Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Commit

Permalink
Upgrade to AlfredSwift version with better version parsing
Browse files Browse the repository at this point in the history
AlfredGifBrowser.app stopped working with Alfred v4.5. The bug was
in the AlfredSwift library.  Before `v0.1.4`, AlfredSwift expected
both minor and patch versions to be present in order to parse
a version-string correctly. Thus, AlfredSwift considered `4.5`
to be an invalid version. This, in turn made AlfredGifBrowser crash.
From `v0.1.4` onwards, AlfredSwift correctly parses `4.5` as
`4.5.0`. Thus, upgrading to it fixes #8 and makes the GIF browser
work again.
  • Loading branch information
mr-pennyworth committed Jul 4, 2021
1 parent 8fc5228 commit e3a9e0e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions alfred-gif-browser/AlfredGifBrowser.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 10.14;
MARKETING_VERSION = 0.3.3;
MARKETING_VERSION = 0.3.5;
OTHER_CODE_SIGN_FLAGS = "--deep";
PRODUCT_BUNDLE_IDENTIFIER = mr.pennyworth.AlfredGifBrowser;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -342,7 +342,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 10.14;
MARKETING_VERSION = 0.3.3;
MARKETING_VERSION = 0.3.5;
ONLY_ACTIVE_ARCH = YES;
OTHER_CODE_SIGN_FLAGS = "--deep";
PRODUCT_BUNDLE_IDENTIFIER = mr.pennyworth.AlfredGifBrowser;
Expand Down Expand Up @@ -388,7 +388,7 @@
repositoryURL = "https://github.com/mr-pennyworth/AlfredSwift";
requirement = {
kind = upToNextMinorVersion;
minimumVersion = 0.1.0;
minimumVersion = 0.1.4;
};
};
D0E43DF9265CB0330016375D /* XCRemoteSwiftPackageReference "FileWatcher" */ = {
Expand Down
2 changes: 1 addition & 1 deletion info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -2272,7 +2272,7 @@ Check for updates: once a week</string>
<string>giphy_key</string>
</array>
<key>version</key>
<string>0.3.4</string>
<string>0.3.5</string>
<key>webaddress</key>
<string>https://github.com/mr-pennyworth/alfred-gif#readme</string>
</dict>
Expand Down

0 comments on commit e3a9e0e

Please sign in to comment.