Try to add a new exported state variable #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug was just because I hadn't merged in the new dust changes. Now I just need to update the tests to reflect this new state variable. |
|
One (optional) improvement that could be good is to find a way to suppress the warning that |
this was something we supported in odin1 and it will come back at some point (you can control how angry odin will be at you for unused things). But anything other than error forces me to think about the interface for that control, so I have paused on that for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking ahead, I'm going to eventually want an indicator of how many outbreaks there really are, not just those declared. I tried to add this new exported state variable,
infected_herds_regionby following the guide of what was there for the others.It should just tally how many herds there are with ANY infected cows for each region.
But perhaps expectedly it's failing, could do with some insight into why.