Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(health): don't warn if nvim-dap is not configured #667

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat(health): don't warn if nvim-dap is not configured #667

merged 1 commit into from
Jan 27, 2025

Conversation

b1nhack
Copy link
Contributor

@b1nhack b1nhack commented Jan 25, 2025

We should disable the dap health check when the dap feature is disabled.

@github-actions GitHub Actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

mrcjkb
mrcjkb requested changes Jan 25, 2025
View reviewed changes
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏
I would suggest to generalise this, by adding an is_enabled() function to the class.

@mrcjkb mrcjkb enabled auto-merge (squash) January 26, 2025 00:13
auto-merge was automatically disabled January 27, 2025 10:36

Head branch was pushed to by a user without write access

@b1nhack
Copy link
Contributor Author

b1nhack commented Jan 27, 2025

Changed optional to is_optional for consistency.

@b1nhack b1nhack requested a review from mrcjkb January 27, 2025 11:11
@mrcjkb mrcjkb merged commit 9fd44c3 into mrcjkb:master Jan 27, 2025
6 checks passed
@mrcjkb mrcjkb mentioned this pull request Jan 27, 2025
Merged
mrcjkb pushed a commit that referenced this pull request Jan 27, 2025
@b1nhack @mrcjkb
feat(health): don't warn if nvim-dap is not configured (#667)
0621e0c
@mrcjkb mrcjkb changed the title feat(health): disable dap health check when dap is disabled feat(health): don't warn if nvim-dap is not configured Jan 27, 2025
@mrcjkb
Copy link
Owner

mrcjkb commented Jan 27, 2025 •
edited
Loading

dap.disable is not a field that exists.
I've reverted the change and replaced it with: 630c8b0

@b1nhack
Copy link
Contributor Author

b1nhack commented Jan 28, 2025

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b1nhack @mrcjkb