Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(termopen): replace termopen with jobstart #675

Merged
merged 1 commit into from
Jan 31, 2025
+8 −1
Merged

revert(termopen): replace termopen with jobstart #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lua/rustaceanvim/executors/termopen.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,15 @@ local M = {
-- close the buffer when escape is pressed :)
vim.keymap.set('n', '<Esc>', '<CMD>q<CR>', { buffer = latest_buf_id, noremap = true })

-- TODO(0.11): Replace with vim.fn.jobstart(full_command, { term = true })
-- run the command
vim.fn.jobstart(full_command, { term = true })
---@diagnostic disable-next-line: deprecated
if type(vim.fn.termopen) == 'function' then
---@diagnostic disable-next-line: deprecated
vim.fn.termopen(full_command)
else
vim.fn.jobstart(full_command, { term = true })
end

-- when the buffer is closed, set the latest buf id to nil else there are
-- some edge cases with the id being sit but a buffer not being open
Expand Down