Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Ignore diagnostic() method in Deno. #29522

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

Mutefish0
Copy link
Contributor

@Mutefish0 Mutefish0 commented Sep 28, 2024

I've ported a game to Deno using Three.js. However, diagnostic filters aren’t supported in wgpu, which Deno's WebGPU is based on.

Tracking issue:
gfx-rs/wgpu#5320

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.15
170.18
687.15
170.18
+0 B
+0 B
WebGPU 805.82
216.97
805.82
216.97
+5 B
+6 B
WebGPU Nodes 805.33
216.83
805.33
216.83
+5 B
+5 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.85
111.79
462.85
111.79
+0 B
+0 B
WebGPU 535.59
144.55
535.6
144.56
+5 B
+5 B
WebGPU Nodes 491.75
134.31
491.75
134.31
+5 B
+4 B

@Mugen87 Mugen87 added this to the r170 milestone Sep 29, 2024
@mrdoob mrdoob merged commit fb5406d into mrdoob:dev Sep 30, 2024
12 checks passed
@Mugen87 Mugen87 changed the title WebGPURenderer: Ignore diagnostic() method in Deno WebGPURenderer: Ignore diagnostic() method in Deno. Sep 30, 2024
@ErichDonGubler
Copy link

Heads up: Once gfx-rs/wgpu#6148 lands, and it's consumed in Deno, you should be able to revert this.

CC @crowlKats, who maintains Deno's WebGPU implementation. I'm not sure if or how Deno is tracking this functionality.

@crowlKats
Copy link

crowlKats commented Oct 25, 2024

nope, we are not tracking this functionality, but i'll be keeping an eye on it now and make sure we update deno once its available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants