New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineGeometry: Override setFromPoints method #29681

Open

felixwri wants to merge 2 commits into mrdoob:dev from felixwri:line2-set-from-positions

felixwri commented Oct 17, 2024

Description

This overrides the setFromPoints method inherited by BufferGeometry so that it can be used to set the vertex positions on a LineGeometry.

const points = curve.getPoints(100);

const geometry = new LineGeometry();
geometry.setFromPoints(points); // Takes Vector3[] or Vector2[]

I think this could be more intuitive since previously, setFromPoints would be suggested by intellisense but would not work.

felixwri added 2 commits

October 17, 2024 12:12


          Added setFromPoints method to LineGeometry

932327b


          Added method to the docs

3bd095c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet