-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLRenderer: Allow for copying textures from the canvas, remove copyFramebufferToTexture #29772
Draft
gkjohnson
wants to merge
17
commits into
mrdoob:dev
Choose a base branch
from
gkjohnson:remove-framebuffer-copy
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−285
Draft
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3af6df7
Add mipmap copy support
gkjohnson 14e1e0e
unbind buffers
gkjohnson acaae84
working function implementation
gkjohnson 4687c22
Support signature deprecation
gkjohnson f20a792
update docs
gkjohnson 251a106
add basic logic for copying from canvas
gkjohnson 12ae3a1
Infer the mipmap sizes of the src texture
gkjohnson 9827ffd
Merge branch 'mipmap-copy' into remove-framebuffer-copy
gkjohnson b65ac8f
rework
gkjohnson 16714ef
Update demo
gkjohnson 8e949c7
Deprecate copyFramebufferToTexture
gkjohnson 1d6b641
Docs update
gkjohnson 6207ff4
Deprecate "FramebufferTexture"
gkjohnson 90fe314
Remove usage of FrameBufferTexture
gkjohnson 5d73af1
Force the canvas frame buffer
gkjohnson baeb835
Remove source texture check
gkjohnson 0e3a18e
Merge remote-tracking branch 'mrdoob/dev' into remove-framebuffer-copy
gkjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating an "empty" texture that is only useful for copying data into, as FramebufferTexture was, is a bit more awkward, now. In the past I've used RenderTargets to serve as "empty" texture vessels for copying data around into but there's still some extra memory overhead in that case (depth buffers, etc).