Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTAONode: Add resolutionScale. #29826

Merged
merged 1 commit into from
Nov 6, 2024
Merged

GTAONode: Add resolutionScale. #29826

merged 1 commit into from
Nov 6, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 6, 2024

Related issue: -

Description

There are scenes where you can achieve good results when the AO runs at half-resolution. Similar to SSRNode, the PR adds resolutionScale. Default is 1 though so this change does not affect existing scenes.

The PR also contains a bit of clean up to make some uniforms private in DenoiseNode and GTAONode which are not meant to be set by users.

@Mugen87 Mugen87 added this to the r171 milestone Nov 6, 2024
@Mugen87 Mugen87 merged commit 7905c96 into mrdoob:dev Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant