Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSLNodeBuilder: Added support for .wrap* using biquadraticTexture #29828

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 7, 2024

Related issue: #28673

Description

Added support for texture.wrap* using biquadraticTexture, or TSL texture() used in vertex stage.
RepeatWrapping, ClampToEdgeWrapping and MirroredRepeatWrapping.

/cc @brunosimon

@sunag sunag added this to the r171 milestone Nov 7, 2024
@sunag sunag changed the title WGSLNodeBuilder: Added support for wrap* using biquadraticTexture WGSLNodeBuilder: Added support for .wrap* using biquadraticTexture Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.22
171.45
692.22
171.45
+0 B
+0 B
WebGPU 823.66
222.44
825.17
222.84
+1.51 kB
+400 B
WebGPU Nodes 822.78
222.25
824.29
222.63
+1.51 kB
+387 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.58
112.26
464.58
112.26
+0 B
+0 B
WebGPU 543.88
147.3
545.38
147.7
+1.5 kB
+400 B
WebGPU Nodes 499.82
137.03
501.32
137.43
+1.5 kB
+397 B

@sunag sunag marked this pull request as ready for review November 7, 2024 06:08
@sunag sunag merged commit d2875f6 into mrdoob:dev Nov 7, 2024
12 checks passed
@sunag sunag deleted the dev-wrapping-textures branch November 7, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant