chore: revert signMessage type change and override in signAccountLabe…

…lMemo
mrgnlabs · Oct 20, 2024 · ad6b824 · ad6b824
1 parent 0119743
commit ad6b824
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/marginfi-v2-ui-state/src/lib/firebase.ts b/packages/marginfi-v2-ui-state/src/lib/firebase.ts
@@ -264,7 +264,8 @@ async function signAccountLabelMemo(wallet: Wallet, account: string, label: stri
     if (signatureResult instanceof Uint8Array) {
       signatureArray = signatureResult;
     } else {
-      signatureArray = new Uint8Array(signatureResult.signature);
+      const phantomSignatureResult = signatureResult as { signature: ArrayBuffer };
+      signatureArray = new Uint8Array(phantomSignatureResult.signature);
     }
 
     const signedData = JSON.stringify({

diff --git a/packages/mrgn-common/src/types.ts b/packages/mrgn-common/src/types.ts
@@ -13,9 +13,7 @@ export type Amount = BigNumber | number | string;
 
 export type Wallet = Pick<SignerWalletAdapter, "signAllTransactions" | "signTransaction"> & {
   publicKey: PublicKey;
-  // phantom window provider returns { signature: ArrayBuffer }
-  // wallet adapter returns Uint8Array
-  signMessage?: (message: Uint8Array) => Promise<Uint8Array | { signature: ArrayBuffer }>;
+  signMessage?: (message: Uint8Array) => Promise<Uint8Array>;
 };
 
 export interface TransactionOptions extends ConfirmOptions {