fix(mfi-v2-trading): added config for flashloan actionbox platform fee #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
k0beLeenders
force-pushed
the
fix/flashloan-actionbox-fee
branch
from
7769557
to
fc4a581
Compare
k0beLeenders
force-pushed
the
fix/flashloan-actionbox-fee
branch
from
fc4a581
to
d1e8ee2
Compare
borcherd
reviewed
Oct 24, 2024
| @@ -142,7 +146,8 @@ export function useLoopSimulation({ | |||
| amount, | |||
| slippageBps, | |||
| marginfiClient.provider.connection, | |||
| 0 //priorityFee | |||
There was a problem hiding this comment.
why no priority fee here? Arent you importing that from the actionboxstore too?
There was a problem hiding this comment.
priority fee isn't used anymore, we only use bundletip
| @@ -119,7 +123,8 @@ export function useRepayCollatSimulation({ | |||
| amount, | |||
| slippageBps, | |||
| marginfiClient.provider.connection, | |||
| 0 //priorityFee | |||
| 0, //priorityFee, | |||
chambaz
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a missing platform fee config on the new actionbox v2, this adds it again
this branch will only build once stake box is merged in