Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix validation for select_prompt option #441

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

mrjones2014
Copy link
Owner

Resolves: #440

How to Test

  1. :lua require('legendary').find({ select_prompt = 'Custom prompt' })

Testing for Regressions

I have tested the following:

  • Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
  • Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
  • Triggering commands from legendary.nvim in all modes (normal, insert, visual)
  • Creating commands via legendary.nvim, then running the command manually from the command line
  • augroup/autocmds created through legendary.nvim work correctly

@mrjones2014 mrjones2014 merged commit d4f7b59 into master Mar 23, 2024
2 checks passed
@mrjones2014 mrjones2014 deleted the mrj/440/fix-select-prompt-validator branch March 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: select_prompt refuses a string but accept a function
1 participant