Skip to content

Commit

Permalink
Use ansible_facts to reference facts
Browse files Browse the repository at this point in the history
By default, Ansible injects a variable for every fact, prefixed with
ansible_. This can result in a large number of variables for each host,
which at scale can incur a performance penalty. Ansible provides a
configuration option [0] that can be set to False to prevent this
injection of facts. In this case, facts should be referenced via
ansible_facts.<fact>.

This change updates all references to Ansible facts from using
individual fact variables to using the items in the
ansible_facts dictionary. This allows users to disable fact variable
injection in their Ansible configuration, which may provide some
performance improvement.

[0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars
  • Loading branch information
markgoddard committed May 13, 2021
1 parent 098bd79 commit 73b6bce
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tasks/centos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
become: true

- include_tasks: amazon.yml
when: ansible_system_vendor == 'Amazon EC2'
when: ansible_facts.system_vendor == 'Amazon EC2'

- name: centos | installing sg3_utils
package:
Expand Down
4 changes: 2 additions & 2 deletions tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
# tasks file for ansible-manage-lvm
- include_tasks: debian.yml
when: ansible_os_family == "Debian"
when: ansible_facts.os_family == "Debian"

- include_tasks: centos.yml
when: ansible_os_family == "RedHat"
when: ansible_facts.os_family == "RedHat"

- include_tasks: manage_lvm.yml
when:
Expand Down

0 comments on commit 73b6bce

Please sign in to comment.