Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimizing the patterns set matching by exiting early #475

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

mrmlnc
Copy link
Owner

@mrmlnc mrmlnc commented Jan 3, 2025

What is the purpose of this pull request?

Optimization of deep directory asynchronous crawls by ~5-10%.

// Without options (~5%)

Label              import.time (time)  time (time)       memory (memory)     entries (value)  process.time (time)
-----------------  ------------------  ----------------  ------------------  ---------------  -------------------
async current **   26.208ms ±3.187%    64.608ms ±2.053%  11.031 MiB ±4.829%  17452 ±0.000%    123.354ms ±2.018%  
async previous **  24.411ms ±3.881%    66.132ms ±4.072%  11.163 MiB ±6.652%  17452 ±0.000%    120.214ms ±2.595% 

// With absolute: true (~10%)

Label              import.time (time)  time (time)        memory (memory)      entries (value)  process.time (time)
-----------------  ------------------  -----------------  -------------------  ---------------  -------------------
async current **   26.501ms ±3.421%    106.862ms ±5.315%  20.176 MiB ±11.108%  17452 ±0.000%    165.816ms ±3.340%  
async previous **  24.319ms ±4.100%    119.074ms ±1.658%  15.928 MiB ±6.148%   17452 ±0.000%    174.286ms ±1.540% 

What changes did you make? (Give an overview)

It is not necessary to perform unnecessary actions if they do not fit into a positive pattern or if there is no relevant pattern to follow by type.

@mrmlnc mrmlnc added this to the 4.0.0 milestone Jan 3, 2025
@mrmlnc mrmlnc marked this pull request as ready for review January 3, 2025 20:53
@mrmlnc mrmlnc merged commit bbc7d07 into master Jan 3, 2025
20 checks passed
@mrmlnc mrmlnc deleted the optimize_entry_filter branch January 4, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant