Updates for Keycloak 24&25 #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jermarchand do you think you're going to proceed with this PR? It is very promising and I'd like to use those features you added. |
jermarchand
force-pushed
the
master
branch
2 times, most recently
from
aac9281
to
ea4ea2a
Compare
|
Is this pull request still relevant ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The main feature in Keycloak 24 is "Supported user profile and progressive profiling" (https://www.keycloak.org/2024/03/keycloak-2400-released.html).
There is a "Breaking changes to the User Profile SPI".
Initialy I tried to update tests to be compatible 'pre' and 'post' version 24.
But too much use of skipIfVersionIsLessThanOrEqualTo method makes reading the tests complicated.
I don't have enougth time to do it, so I create this PR WITHOUT testing versions less than 24 AND with "Breaking changes" on User Profile.
I propose this PR with :
saml_organizationto SAML clients tests (just for version Keycloak 25)sync_modeto Idp tests (Otherwise tests failed)It's "Work In Progress", I have to :
All comments are welcome