Make colored-diff also work on small dataset #150
Merged
+150
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeotuan
commented
Sep 4, 2024
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
zeotuan
commented
Sep 7, 2024
|
|
||
| "Correctly mark unequal elements" in { |
There was a problem hiding this comment.
@SemyonSinchenko , @alfonsorr - I added two small tests to validate output message of assertion. We can use extractColorGroup to add more robust testing on the message. I will create separate issue for improving tests.
alfonsorr
approved these changes
Sep 11, 2024
Thanks! Let's add that as part of the CI pipelines. It should help with the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #136 and extension of #143 to support colored-diff on small dataset comparison