Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable windows instead of popovers #301

Closed
wants to merge 3 commits into from
Closed

Reusable windows instead of popovers #301

wants to merge 3 commits into from

Conversation

sim6
Copy link
Contributor

@sim6 sim6 commented May 24, 2024

This changes improve noticeably the performance when list a lot of tasks.

@sim6 sim6 force-pushed the reusable_windows_instead_of_popovers branch from e287b60 to eceda17 Compare May 24, 2024 08:19
@sim6 sim6 mentioned this pull request May 24, 2024
Closed
@sim6 sim6 force-pushed the reusable_windows_instead_of_popovers branch from eceda17 to 155829e Compare May 24, 2024 08:34
@mrvladus
Copy link
Owner

Looks good, but I don't think we need details window. Popup is enough. And you can remove RAISED style for ToolbarView. And for the priority window we need to add navigation-sidebar class for ListBox. I wanted to redisign it later, but it will be good for now.

sim6 added 3 commits May 24, 2024 15:00
@sim6
Priority Window
a4deeb4 
Use a reusable Priority Window instead of a Popover for each task.

Signed-off-by: Simó Albert i Beltran <[email protected]>
@sim6
Tag Window
d0e61e2 
Use reusable Tag Window instead of a Popover for each task

Signed-off-by: Simó Albert i Beltran <[email protected]>
@sim6
Detail Window
0ee9d0b 
Use reusable Detail Window instead of a Popover for each task

Signed-off-by: Simó Albert i Beltran <[email protected]>
@sim6 sim6 force-pushed the reusable_windows_instead_of_popovers branch from 155829e to 0ee9d0b Compare May 24, 2024 13:00
@sim6
Copy link
Contributor Author

sim6 commented May 24, 2024 •
edited
Loading

Thanks. I removed RAISED style and added navigation-sidebar class. About window Details, with the current code there are a menu with color widgets for each task, so a lot of widgets in a list with a lot of tasks and raises for each new task, but with window Details the number of widgets are fixed and reused for each task.

@mrvladus
Copy link
Owner

mrvladus commented May 24, 2024 •
edited
Loading

Is there any way we can reuse popups?

@sim6
Copy link
Contributor Author

sim6 commented May 24, 2024

Sure, but I prefer Adw.Dialog because I like the application more homogeneous and also it is more usable on small touch screens like the one Librem5 comes with.

@mrvladus
Copy link
Owner

Closing this because of #339. I've implemented almost all dialogs. Python was getting in the way of improving performance.

@mrvladus mrvladus closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sim6 @mrvladus