Java tuple fix #21
Open
Java tuple fix #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In former implementation, tuple in idl is realized as generic class Tuple<T, U>. But it cannot be deserialized in msgpack type.
This pull request is patch for this problem.
Instead of creating generic type, concrete class is created for each tuple type appeared in .idl file.
For example, tuple<string, double> is realized as TupleStringDouble class and tuple<tuple<string, double>, double> is TupleTupleStringDoubleDouble.
(This class name is somewhat lengthy and difficult to read, so if more clever naming is available, I'd like to choose it.)