Prevent memory leak when a recursive unpacker raises an exception #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
recursive-raise-leak
branch
from
23f5821 to
eec6eee
Compare
|
I need to check if perhaps we have a similar issue with recursive packers. |
casperisfine
force-pushed
the
recursive-raise-leak
branch
from
eec6eee to
f028dca
Compare
The child stack wouldn't be popped nor freed. Additionally, even once the packer was freed, only the latest stack would be freed, all the parent stack would be leaked. Practically speaking, every time a recursive unpacker would raise, 4kiB would be leaked.
casperisfine
force-pushed
the
recursive-raise-leak
branch
from
f028dca to
8a79706
Compare
peterzhu2118
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The child stack wouldn't be popped nor freed.
Additionally, even once the packer was freed, only the latest stack would be freed, all the parent stack would be leaked.
Practically speaking, every time a recursive unpacker would raise, 4kiB would be leaked.