Skip to content

Commit

Permalink
#358: Switch dialogs from native-dialog to rfd
Browse files Browse the repository at this point in the history
  • Loading branch information
mtkennerly committed Nov 7, 2024
1 parent 2a694c1 commit 679e632
Show file tree
Hide file tree
Showing 10 changed files with 274 additions and 250 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
with:
key: ${{ matrix.os }}-${{ matrix.rust-target }}
- if: ${{ matrix.os == 'ubuntu-20.04' }}
run: sudo apt-get update && sudo apt-get install -y gcc libxcb-composite0-dev
run: sudo apt-get update && sudo apt-get install -y gcc libxcb-composite0-dev libgtk-3-dev
- run: cargo build --release
- if: ${{ matrix.tar }}
run: |
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
with:
key: ${{ matrix.os }}
- if: ${{ matrix.os == 'ubuntu-latest' }}
run: sudo apt-get update && sudo apt-get install -y gcc libxcb-composite0-dev
run: sudo apt-get update && sudo apt-get install -y gcc libxcb-composite0-dev libgtk-3-dev
- if: ${{ matrix.os == 'windows-latest' }}
run: reg import tests/ludusavi.reg
- if: ${{ matrix.os == 'windows-latest' }}
Expand All @@ -106,5 +106,7 @@ jobs:
- uses: Swatinem/rust-cache@v2
with:
key: ${{ matrix.os }}
- if: ${{ matrix.os == 'ubuntu-latest' }}
run: sudo apt-get update && sudo apt-get install -y gcc libxcb-composite0-dev libgtk-3-dev
- run: cargo fmt --all -- --check
- run: cargo clippy --workspace -- --deny warnings
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Changed:
* Windows registry backups are now saved as `*.reg` files instead of `*.yaml`.
Existing backups will not be affected.
* Dialogs (folder picker and `wrap --gui` prompts) now use GTK on Linux.
The previous system relied on Zenity/KDialog,
which could behave poorly depending on the version or in a Flatpak context.
* Fixed:
* The registry format change also resolved an issue where very large (> 100 MB)
`registry.yaml` files could be slow to read and consume a lot of extra memory,
Expand Down
Loading

0 comments on commit 679e632

Please sign in to comment.