Fix empty list factory method generation

- Do not generate and empty list factory method in case we have type mapping with conversion Issue: #160
muehmar · Oct 8, 2024 · 6f748c1 · 6f748c1
1 parent 473838d
commit 6f748c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.../github/muehmar/gradle/openapi/generator/java/generator/array/FactoryMethodGenerator.java b/.../github/muehmar/gradle/openapi/generator/java/generator/array/FactoryMethodGenerator.java
@@ -78,6 +78,7 @@ private static Generator<JavaArrayPojo, PojoSettings> emptyFactoryMethod() {
   }
 
   private static boolean arrayPojoHasStandardListType(JavaArrayPojo arrayPojo) {
-    return arrayPojo.getJavaArrayType().getQualifiedClassName().equals(QualifiedClassNames.LIST);
+    return arrayPojo.getJavaArrayType().getQualifiedClassName().equals(QualifiedClassNames.LIST)
+        && arrayPojo.getJavaArrayType().hasNoApiTypeDeep();
   }
 }
diff --git a/...adle/openapi/generator/java/generator/array/__snapshots__/FactoryMethodGeneratorTest.snap b/...adle/openapi/generator/java/generator/array/__snapshots__/FactoryMethodGeneratorTest.snap
@@ -17,7 +17,6 @@ public static PosologyDto empty() {
 arrayPojoFullyTypeMappedWithConversion=[
 com.custom.CustomList
 com.custom.CustomString
-java.util.Collections
 java.util.List
 java.util.function.Function
 
@@ -33,9 +32,6 @@ public static PosologyDto fromItems(CustomList<CustomString> items) {
   );
 }
 
-public static PosologyDto empty() {
-  return fromItems(Collections.emptyList());
-}
 ]