Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-index subtree on move #22

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Re-index subtree on move #22

merged 1 commit into from
Nov 13, 2021

Conversation

peterkeung
Copy link
Member

Currently, eZ Find does not re-index a node's subtree when the node is moved. This PR uses the same strategy that we use when the node's visibility is toggled, which is to defer the re-index to the ezfindindexsubtree cronjob.

@peterkeung
Copy link
Member Author

This PR is dedicated to @benkmugo

@peterkeung
Copy link
Member Author

Upstream PR unlikely to get any attention: ezsystems#223

Copy link
Member

@benkmugo benkmugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, especially re-using the same approach as updateNodeVisibility to avoid timeouts.

@pkamps pkamps merged commit 29686e9 into master Nov 13, 2021
@pkamps pkamps deleted the reindex_subtree_on_move_mugo branch November 13, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants