Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix display when ad-block triggers #44567

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 26, 2024

Since easylist/easylist#20644 is live, e.g. with uBlock Origin, the docs look broken:

SCR-20241126-tjum

https://mui.com/material-ui/react-alert/

Instead, we can add some margin, in case the block gets removed.

I also used the opportunity to make it harder to have selectors that reliably work for this block.

Preview:

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product labels Nov 26, 2024
@mui-bot
Copy link

mui-bot commented Nov 26, 2024

Netlify deploy preview

https://deploy-preview-44567--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ab4fc65

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. 👍

@oliviertassinari oliviertassinari enabled auto-merge (squash) November 27, 2024 10:08
@oliviertassinari oliviertassinari merged commit c45f084 into mui:master Nov 27, 2024
18 checks passed
@oliviertassinari oliviertassinari deleted the docs-fix-ad-block branch January 28, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants