[docs-infra] Move Ukraine banner to the bottom #45135
Merged
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
remove-ukrain-banner
branch
from
3da293a to
4bd4485
Compare
Netlify deploy previewhttps://deploy-preview-45135--material-ui.netlify.app/ Bundle size report |
| @@ -44,7 +44,7 @@ export default function DiamondSponsors() { | |||
| const t = useTranslate(); | |||
|
|
|||
| return ( | |||
| <Stack direction="column" sx={{ mt: 2 }}> | |||
| <Stack direction="column" sx={{ mt: 2, mx: 0.5 }}> | |||
There was a problem hiding this comment.
I kill two birds with one stone here. It changes the class name generated, preventing this from working https://github.com/easylist/easylist/blob/18821365f63fa7ee8bcb03f732df2d67fd86dde2/easylist/easylist_specific_hide.txt#L2759 😆
Similar to #44567
mnajdova
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #34795. From #34795 (comment), it seems that all the projects that are still maintained and that used to show a banner removed it. This change should help a bit with #40977 and the UX, reducing the visual distraction. At this stage, most people are pretty much aware of how we stand.
Related to #39495.
Preview: https://deploy-preview-45135--material-ui.netlify.app/material-ui/react-button-group/
Context, I noticed this, because I was engaging with https://mui.zendesk.com/agent/tickets/25472.