[Menu] Deprecate *Props and complete slots, slotProps
#44913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
the
component: menu
Netlify deploy previewTextField: parsed: +0.30% , gzip: +0.25% Bundle size reportDetails of bundle changes (Toolpad) |
39 tasks
DiegoAndai
reviewed
Jan 8, 2025
DiegoAndai
reviewed
Jan 9, 2025
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
DiegoAndai
reviewed
Feb 7, 2025
Comment on lines
+206
to
+209
| const resolvedTransitionProps = | ||
| typeof externalForwardedProps.slotProps.transition === 'function' | ||
| ? externalForwardedProps.slotProps.transition(ownerState) | ||
| : externalForwardedProps.slotProps.transition; |
There was a problem hiding this comment.
Should we use mergeSlotProps here?
Comment on lines
+229
to
+231
| typeof slotProps.backdrop === 'function' | ||
| ? slotProps.backdrop(ownerState) | ||
| : slotProps.backdrop, |
There was a problem hiding this comment.
Should we use mergeSlotProps here?
Comment on lines
+52
to
+55
| const transitionProps = | ||
| typeof slotProps?.transition === 'function' | ||
| ? slotProps.transition(ownerState) | ||
| : slotProps?.transition; |
There was a problem hiding this comment.
Should we use mergeSlotProps here?
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41281
MenuListPropsandTransitionProps.slots.transitionandslots.list