Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix permissions in no-response workflow #6658

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Oct 28, 2022

Fixes a regression from #6396 (comment)

Signed-off-by: Andrew Cherniavskii <[email protected]>
@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Oct 28, 2022
@mui-bot
Copy link

mui-bot commented Oct 28, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-undefined--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 548.5 991 715.9 743.46 164.974
Sort 100k rows ms 671.4 1,190 671.4 950.6 180.81
Select 100k rows ms 223 390.8 229.5 271.78 63.902
Deselect 100k rows ms 144.6 283.9 193.4 214.58 57.843

Generated by 🚫 dangerJS against efd9b29

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it needs write permission on PR

Did you try it on your repo to verify it fixes the problem?

.github/workflows/no-response.yml Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Andrew Cherniavskii <[email protected]>
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I have made a dumb mistake on this one, thanks for the 🧹 behind me. We can see the error in https://github.com/mui/mui-x/actions/runs/3350385087/jobs/5551157153

Screenshot 2022-10-29 at 15 45 50


I have applied the same fix to the other repositories.


I went on the older issues to fill the gap where the GitHub Action didn't run these last few days.


I have updated MUI org permissions to be:

Screenshot 2022-10-29 at 16 24 53


I have opened lee-dohm/no-response#377 hoping that it might get released, our GitHub Actions should have failed.

Screenshot 2022-10-29 at 16 26 41

@oliviertassinari oliviertassinari added the regression A bug, but worse label Oct 29, 2022
@oliviertassinari oliviertassinari changed the title [core] Fix no-response workflow [core] Fix permissions in no-response workflow Oct 29, 2022
oliviertassinari added a commit to mui/material-ui that referenced this pull request Oct 29, 2022
oliviertassinari added a commit to mui/toolpad that referenced this pull request Oct 29, 2022
oliviertassinari added a commit to mui/mui-design-kits that referenced this pull request Oct 29, 2022
@cherniavskii cherniavskii merged commit 2690879 into next Oct 31, 2022
@cherniavskii cherniavskii deleted the cherniavskii-noReponse-permissions branch October 31, 2022 09:12
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants