Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decoder CheckIntegrity now return two values #95

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

muktihari
Copy link
Owner

  • CheckIntegrity sequence completed and any error encountered. sequence completed is useful to know how many FIT sequences are valid so we can recover it.
  • Reduce alloc on initDecodeHeaderOnce() by inlining the function and variable.
  • Move header validity order, should be check FileHeader's Size and bytes 8-12 first so we can sure that it's a FIT file, then we validate the other values.

@muktihari muktihari added the enhancement New feature or request label Jan 6, 2024
@muktihari muktihari self-assigned this Jan 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (854b1ce) 99.89% compared to head (a7faafc) 99.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files          42       42              
  Lines        3841     3839       -2     
==========================================
- Hits         3837     3835       -2     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 82b5514 into master Jan 6, 2024
1 check passed
@muktihari muktihari deleted the feat/decoder-check-integrity-return-two-values branch January 6, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants