Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNS server info inconsistencies in settings view #4881

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix DNS server info inconsistencies in settings view #4881

merged 1 commit into from
Aug 1, 2023

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Jul 7, 2023 •
edited by faern
Loading

Custom DNS footer text does not properly change its visibility:

  1. Custom dns footer does not appear when enabling any of content blockers.
  2. Custom dns footer may appear in response to expanding WireGuard ports section when conditions for the footer text to be visible are satisified.
  3. Custom dns footer, if visible, may leave a blank space behind when it disappears in response to toggling off all of the dns content blockers.

To address this the footer has been converted to a regular cell instead.

This change is Reviewable

@linear
Copy link

linear bot commented Jul 7, 2023

IOS-208 🐞 Custom DNS footer text does not properly change its visibility 🐞

🐞 Custom DNS footer text does not properly change its visibility 🐞

  1. Custom dns footer does not appear when enabling any of content blockers.

  2. Custom dns footer may appear in response to expanding WireGuard ports section when conditions for the footer text to be visible are satisified.

  3. Custom dns footer, if visible, may leave a blank space behind when it disappears in response to toggling off all of the dns content blockers.

    10f973e5-43b2-45ad-8038-4d7522eca78a

@rablador rablador added the iOS Issues related to iOS label Jul 7, 2023
@rablador rablador force-pushed the custom-dns-footer-text-does-not-properly-update-ios-208 branch from 5bf7693 to 2b099ff Compare July 7, 2023 09:04
@rablador rablador marked this pull request as ready for review July 7, 2023 09:04
buggmagnet
buggmagnet approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the custom-dns-footer-text-does-not-properly-update-ios-208 branch from 2b099ff to ad11162 Compare August 1, 2023 13:29
buggmagnet
buggmagnet approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

mojganii
mojganii approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the custom-dns-footer-text-does-not-properly-update-ios-208 branch from ad11162 to 2f81fe9 Compare August 1, 2023 14:28
@buggmagnet buggmagnet merged commit fafe4c9 into main Aug 1, 2023
3 checks passed
@buggmagnet buggmagnet deleted the custom-dns-footer-text-does-not-properly-update-ios-208 branch August 1, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buggmagnet buggmagnet buggmagnet approved these changes

@mojganii mojganii mojganii approved these changes

Assignees
No one assigned
Labels
iOS Issues related to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rablador @buggmagnet @mojganii