Change wireguard obfuscation default from off to auto and migrate users #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulthe
force-pushed
the
change-wireguard-obfuscation-default-to-auto-des-544
branch
from
f9c6a55
to
0c7cc7e
Compare
hulthe
commented
Feb 27, 2024
hulthe
force-pushed
the
change-wireguard-obfuscation-default-to-auto-des-544
branch
from
0c7cc7e
to
975106c
Compare
- Change `selected_obfuscation` default to `auto`. - Migrate `selected_obfuscation` from `off` to `auto` for existing users.
hulthe
force-pushed
the
change-wireguard-obfuscation-default-to-auto-des-544
branch
from
975106c
to
436f2ca
Compare
Make it not take a mut ref to the json value
hulthe
force-pushed
the
change-wireguard-obfuscation-default-to-auto-des-544
branch
from
436f2ca
to
6eb4640
Compare
faern
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Reviewed 5 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)
mullvad-daemon/src/migrations/v6.rs line 27 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
note to self
This is good. The migration should have a doc comment explaining what settings it changes and how. 👍
faern
deleted the
change-wireguard-obfuscation-default-to-auto-des-544
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto.offtoautoautoshould arguably have been the default from the start, so this PR intends to address that. We believe the benefit to Mullvad users from defaulting obfuscation toauto(which in practice will meanon) outweighs the potential consequences of turning obfuscation on after they have explicitly decided to turn it off.This change is