Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use production secrets #5882

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update to use production secrets #5882

merged 1 commit into from
Mar 1, 2024

Conversation

niklasberglund
Copy link
Collaborator

@niklasberglund niklasberglund commented Feb 29, 2024

The configuration options NO_TIME_ACCOUNT_NUMBER and HAS_TIME_ACCOUNT_NUMBER are specified per configuration in UITests.xcconfig now. This PR reflects this change in the names of GitHub action secrets.

For now only login tests run and should run in production environment.


This change is Reviewable

@niklasberglund niklasberglund added the iOS Issues related to iOS label Feb 29, 2024
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit 22953bb into main Mar 1, 2024
2 of 3 checks passed
@buggmagnet buggmagnet deleted the updated-secret-names branch March 1, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants