Fix LocationDataSource crash in MockRelease build #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
locationdatasource-crashes-in-mockrelease-build-ios-526
branch
from
5694c3a
to
4d12a45
Compare
buggmagnet
deleted the
locationdatasource-crashes-in-mockrelease-build-ios-526
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
setRelays(_ response: REST.ServerRelaysResponse, filter: RelayFilter)we construct a list of item lists by looking at the number of data sources (2) and then try to index match with all section cases (1). This causes an index overflow.Fix for the above, plus fix for row scrolling being slightly off.
This change is