Fix end to end test build script #5910
Conversation
There was a problem hiding this comment.
The end to end tests README also mention rustup target install instead of add https://github.com/mullvad/mullvadvpn-app/blob/main/ios/MullvadVPNUITests/README.md#set-up-of-runner-environment
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
.github/workflows/ios-end-to-end-tests.yml line 33 at r1 (raw file):
- name: Configure Rust run: rustup target install aarch64-apple-ios aarch64-apple-ios-sim
The fix is good but I started thinking if we should remove the Rust and Go setup actions, what do you think? Because its a self-hosted runner installed dependencies are persistent. Rust and Go are already installed manually https://github.com/mullvad/mullvadvpn-app/blob/main/ios/MullvadVPNUITests/README.md#set-up-of-runner-environment so don't have to attempt to install them here. Its easier to maintain version numbers of dependencies when its specified in the workflow file rather than manually installed on the computer though. We could also remove the manual steps from the README.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @niklasberglund)
.github/workflows/ios-end-to-end-tests.yml line 33 at r1 (raw file):
Previously, niklasberglund (Niklas Berglund) wrote…
The fix is good but I started thinking if we should remove the Rust and Go setup actions, what do you think? Because its a self-hosted runner installed dependencies are persistent. Rust and Go are already installed manually https://github.com/mullvad/mullvadvpn-app/blob/main/ios/MullvadVPNUITests/README.md#set-up-of-runner-environment so don't have to attempt to install them here. Its easier to maintain version numbers of dependencies when its specified in the workflow file rather than manually installed on the computer though. We could also remove the manual steps from the README.
We can do that in a separate PR
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
.github/workflows/ios-end-to-end-tests.yml line 33 at r1 (raw file):
Previously, buggmagnet wrote…
We can do that in a separate PR
Yes, sounds good 👍
There was a problem hiding this comment.
xcodebuild is failing with error code 65. I did a test run from this branch https://github.com/mullvad/mullvadvpn-app/actions/runs/8185722159
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
|
🚨 End to end tests failed. Please check the failed workflow run. |
This change is