Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show create account confirm when user has account #6951

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kl
Copy link
Contributor

@kl kl commented Oct 9, 2024

Now showing a confirmation dialog when creating an account when the user has already logged in on another account on the device. The text is a placeholder and needs to be decided on.


This change is Reviewable

@kl kl added the Android Issues related to Android label Oct 9, 2024
Copy link

linear bot commented Oct 9, 2024

@kl kl requested a review from Rawa October 9, 2024 11:26
@kl kl force-pushed the reduce-risk-for-account-creation-mistakes-droid-1335 branch from f4d3736 to e0e27fc Compare October 11, 2024 07:10
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)


android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/AccountRepository.kt line 71 at r1 (raw file):

    suspend fun clearAccountHistory(): Either<ClearAccountHistoryError, Unit> =
        managementService.clearAccountHistory().also { _mutableAccountHistory.value = null }

For both this and the one above we should do onRight. Otherwise might reset it incorrectly.

.onRight()

@kl kl force-pushed the reduce-risk-for-account-creation-mistakes-droid-1335 branch from e0e27fc to 8e1eed1 Compare October 11, 2024 08:47
Copy link
Contributor Author

@kl kl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/AccountRepository.kt line 71 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

For both this and the one above we should do onRight. Otherwise might reset it incorrectly.

.onRight()

Done.

@kl kl marked this pull request as ready for review October 11, 2024 08:48
Pururun
Pururun previously approved these changes Oct 11, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)


android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/AccountRepository.kt line 71 at r1 (raw file):

Previously, kl (Kalle Lindström) wrote…

Done.

@kl Forgot to push? the code is still the same.

@kl kl force-pushed the reduce-risk-for-account-creation-mistakes-droid-1335 branch from 8e1eed1 to 519fb65 Compare October 12, 2024 10:33
Copy link
Contributor Author

@kl kl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/AccountRepository.kt line 71 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

@kl Forgot to push? the code is still the same.

Oops 😄 fixed now

@kl kl force-pushed the reduce-risk-for-account-creation-mistakes-droid-1335 branch from 519fb65 to 6c75eed Compare October 15, 2024 09:55
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the reduce-risk-for-account-creation-mistakes-droid-1335 branch from 6c75eed to 57aa888 Compare October 15, 2024 12:38
@Rawa Rawa merged commit 14be365 into main Oct 15, 2024
31 checks passed
@Rawa Rawa deleted the reduce-risk-for-account-creation-mistakes-droid-1335 branch October 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants