Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OpenVPN option when a core privacy feature is enabled #6959

Merged

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Oct 10, 2024

This PR makes the OpenVPN alternative in VPN settings unavailable when a core privacy feature is enabled (DAITA, Multihop, Quantum-resistant tunnel). Texts aren't finished yet.


This change is Reviewable

Copy link

linear bot commented Oct 10, 2024

@raksooo raksooo force-pushed the prevent-user-from-enabling-openvpn-when-a-core-privacy-des-1272 branch 2 times, most recently from c99e32f to 694913c Compare October 11, 2024 07:01
@raksooo raksooo requested a review from hulthe October 11, 2024 07:26
@raksooo raksooo marked this pull request as ready for review October 11, 2024 07:26
@raksooo raksooo force-pushed the prevent-user-from-enabling-openvpn-when-a-core-privacy-des-1272 branch from 694913c to 424d658 Compare October 14, 2024 09:37
hulthe
hulthe previously approved these changes Oct 14, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the prevent-user-from-enabling-openvpn-when-a-core-privacy-des-1272 branch from 424d658 to 1d055d1 Compare October 14, 2024 11:26
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo merged commit 8f5955b into main Oct 14, 2024
11 checks passed
@raksooo raksooo deleted the prevent-user-from-enabling-openvpn-when-a-core-privacy-des-1272 branch October 14, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants