Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api-access-methods.spec - counting of access methods was off #7090

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ test('App should add invalid access method', async () => {
).toEqual(RoutePath.apiAccessMethods);

const accessMethods = page.getByTestId('access-method');
await expect(accessMethods).toHaveCount(3);
// Direct, Bridges, Encrypted DNS Proxy & the non-functioning access method.
await expect(accessMethods).toHaveCount(4);

await expect(accessMethods.last()).toHaveText(NON_FUNCTIONING_METHOD_NAME);
});
Expand Down Expand Up @@ -137,7 +138,8 @@ test('App should edit access method', async () => {
);

const accessMethods = page.getByTestId('access-method');
await expect(accessMethods).toHaveCount(3);
// Direct, Bridges, Encrypted DNS Proxy & the custom access method.
await expect(accessMethods).toHaveCount(4);

await expect(accessMethods.last()).toHaveText(FUNCTIONING_METHOD_NAME);
});
Expand Down Expand Up @@ -172,5 +174,6 @@ test('App should delete method', async () => {

await expect(page.getByText(`Delete ${FUNCTIONING_METHOD_NAME}?`)).toBeVisible();
await page.locator('button:has-text("Delete")').click();
await expect(accessMethods).toHaveCount(2);
// Direct, Bridges, Encrypted DNS Proxy.
await expect(accessMethods).toHaveCount(3);
});
Loading